Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce MEV Blocker refunds test logs #114

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

harisang
Copy link
Contributor

Noticed that the threshold is relatively high for alerts, given the current value of ETH. Also noticed that we get a lot of meaningless logs so decided to reduce those as well.

image

@harisang harisang requested a review from fhenneke August 21, 2024 16:01
Copy link
Contributor

@fhenneke fhenneke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing noisy logs sounds good.

I would not go towards increasing the number of alerts. Unless there is a procedure for how to react to those alerts, they should not be alerts at all.

src/constants.py Outdated Show resolved Hide resolved
@harisang harisang changed the title Decrease MEV Blocker refunds threshold and also reduce relevant logs. Reduce MEV Blocker refunds test logs Aug 22, 2024
@harisang harisang merged commit 25228ec into main Aug 22, 2024
4 checks passed
@harisang harisang deleted the reduce_mev_blocker_refunds_info_msgs branch August 22, 2024 08:03
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants