Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests #115

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Remove tests #115

merged 1 commit into from
Aug 22, 2024

Conversation

fhenneke
Copy link
Contributor

This PR removes tests.

There have been problems with long delays in EBBO tests. This is probably due to the number of tests run and their efficiency. To see where the issues are coming from and for general clean up, some tests are removed from the daemon.

  • Reference solver surplus test: does not work at the moment.
  • Buffer monitoring test: not related to EBBO and seems to slow down the loop significantly
  • CoW AMM commitment test: obsolete with the new version of CoW AMMs

For now the code for tests is not removed completely as they can still be run manually. Longterm, all of the code should be removed as well.

@fhenneke fhenneke requested a review from harisang August 22, 2024 07:40
Copy link
Contributor

@harisang harisang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@fhenneke fhenneke merged commit ca023b1 into main Aug 22, 2024
4 checks passed
@fhenneke fhenneke deleted the remove_tests branch August 22, 2024 08:38
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants