Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting transaction hash from competition data #123

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

fhenneke
Copy link
Contributor

This PR changes how transaction hashes are fetched from competition data.

To support multiple winners, the competition data format was changed to allow for multiple transactions to be associated to an auction. This meant, that instead of a "transactionHash" field containing a string, a "transactionHashes" field containing a vector of strings is stored. This PR, changes the code to use the new convention.

Copy link
Contributor

@harisang harisang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@harisang harisang merged commit 213dd6d into main Oct 22, 2024
4 checks passed
@harisang harisang deleted the fix_tx_hash branch October 22, 2024 14:50
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants