Quote test ignores some errors now #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hash 0xda857a0db563dae564b09febb683fff6150628c1706afc9ebd961c194ca29c5e contains a partially-fillable order with an executed amount which is too small to pay for fees. This resulted in the hash being rechecked over and over. This error is now handled by logging an error and letting the test succeed.
|
This PR seems to include part of the PR that restructures the code. I would suggest that we either do a fix for this error in the old code or wait to merge PR #50 |
fhenneke
force-pushed
the
fix_quote_amount_error
branch
from
03f8d1a to
f237e14
Compare
|
I cherry picked it on top of main now. |
too many locals and too many branches are already fixed on the restructuring branch
harisang
approved these changes
Jun 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hash 0xda857a0db563dae564b09febb683fff6150628c1706afc9ebd961c194ca29c5e
contains a partially-fillable order with an executed amount which is too small
to pay for fees. This resulted in the hash being rechecked over and over.
This error is now handled by logging an error and letting the test succeed.
This catches the errors
'NoLiquidity'and'SellAmountDoesNotCoverFees'.