Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend manual deployments syntax to detect collisions with artifact deployments. #130

Open
nlordell opened this issue Jan 16, 2020 · 0 comments
Open

Extend manual deployments syntax to detect collisions with artifact deployments. #130

nlordell opened this issue Jan 16, 2020 · 0 comments
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@nlordell
Copy link
Contributor

nlordell commented Jan 16, 2020 •
edited
Loading

Currently there is no indication if a manually specified deployment overrides deployments in the Truffle artifact. Add support in code generation and the proc macro to specify if it should be an error or allowed. The current working idea is:

5777! => "0x..." // override network ID 5777 even if it is in the contract.
5777? => "0x..." // Use as a backup if it is not in the contract.
5777 => "0x..." // error if already exists in contract and is a different address.
@nlordell nlordell mentioned this issue Jan 16, 2020
Merged
@nlordell nlordell changed the title Improve manual deployments. Extend manual deployments syntax to detect collisions with artifact deployments. Jan 16, 2020
@nlordell nlordell added the cleanup Clean up the code base and remove some technical debt label May 4, 2020
@nlordell nlordell added enhancement New feature or request and removed cleanup Clean up the code base and remove some technical debt labels May 25, 2020
@nlordell nlordell added this to the 1.0.0 milestone Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@nlordell