Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual deployment address #127

Merged
merged 12 commits into from
Jan 16, 2020
Merged

Manual deployment address #127

merged 12 commits into from
Jan 16, 2020

Conversation

nlordell
Copy link
Contributor

@nlordell nlordell commented Jan 16, 2020

Add ability to manually specify deployment addresses. This closes #99 and #100 .

This PR also adds unit tests in the code generation and derive libraries - so unit tests can be slowly added for code generation as future modification come in.

Test Plan

Unit tests and new example.

@nlordell nlordell requested review from fleupold and bh2smith January 16, 2020 11:52
derive/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@bh2smith bh2smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gotta say, this was a lot to look at... Not sure if I would be able to catch any big problems if there were any.

Copy link
Contributor

@fleupold fleupold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

derive/src/lib.rs Show resolved Hide resolved
generate/src/contract.rs Show resolved Hide resolved
generate/src/lib.rs Show resolved Hide resolved
@nlordell nlordell force-pushed the manual_deployment_address branch from 7f71a22 to eb8aad7 Compare January 16, 2020 21:29
@nlordell nlordell merged commit 30b724d into master Jan 16, 2020
@nlordell nlordell deleted the manual_deployment_address branch January 16, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to generate Contract::deployed regardless of whether there are networks
3 participants