[Easy] Use Self instead of type name
#111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
force-pushed
the
builder_return_self
branch
from
f3ed1a1 to
f541f36
Compare
nlordell
force-pushed
the
builder_return_self
branch
from
f541f36 to
d94c4e3
Compare
fleupold
approved these changes
Jan 8, 2020
|
It would be cool to have! It turns out to be super useful, especially with the builder pattern |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer
Selfover the typename - this is a stylistic change that helps with the builder patterns and makes refactoring a little easier.Closes #110
On hold pending merge of #105