-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support loading artifact from hardhat deployments directory #567
Conversation
6065424
to
e572279
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far only reviewed hardhat dot rs. This is very long. Will have to come back later for more.
I can move example into a separate PR, it that will help with review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The artifact loading code (load_from_directory
) was very linear and easy to review.
One meta-PR comment, I think that the example could have been done in a separate PR, so this one could focus on the relevant ethcontract-common/src/artifact/hardhat.rs
changes. I see that the unit test does depend on the new example output making it hard to split the two, but maybe its worth having manually created test hardhat deployment directory somewhere (kind of like an assertion of "this is the expected format and layout for a deployment directory").
TBH that would be kind of nice (if it isn't too much effort), I admittedly did not review the example carefully at all. If its too much work, don't worry about it. |
Yeah this is difficult to review, I'll split the PR. I wish github allowed tree view the same way Intellij github plugin does. |
e572279
to
167e940
Compare
I've moved example into a separate PR which I'll publish after this one. Filtering contracts by name and unrelated changes to documentation are moved to a separate PR as well. |
From |
Part of #563. Allow loading artifacts from hardhat deployments directory by scanning its contents and parsing all allowed contracts.
Part of #563.
Allow loading artifacts from hardhat deployments directory by scanning its contents and parsing all allowed contracts.