Bump crates to the latest versions #969
Conversation
m-lord-renkse
force-pushed
the
bump-to-latest-versions
branch
12 times, most recently
from
82f5ebd to
197864d
Compare
| @@ -8,7 +8,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| include: | |||
| - rust: 1.70.0 | |||
| - rust: 1.77.2 | |||
There was a problem hiding this comment.
According to the readme the crate has a minimum supported rust version of 1.64 but I guess that ship has already sailed. 😅
Is there a reason this needed to be updated? BTW this exact version is already covered by stable 3 lines down.
There was a problem hiding this comment.
This update is required by the AWS stable release, otherwise it won't compile.
There was a problem hiding this comment.
Overall I'm not a fan of bumping the rust version here. The version you are adding only requires 1.75 according to their readme (MSRV = stable - 2).
Also with the discussion on compatibility of sub-dependency version I think we should not specify the patch level version in our dependencies to give the dependency resolver more room to unify dependency versions.
Also since the MSRV definitely has to be increased (I agree that depending on a stable version of the aws crates makes sense) we should also update the readme of this repo since it mention MSRV as well.
And finally this needs to get published as a new version of the crate. Since we are increasing the MSRV I think to make it a new minor release instead of just doing a patch level release (i.e. 0.25.6 -> 0.26.0). This can be done by using /ci/bump.sh.
m-lord-renkse
force-pushed
the
bump-to-latest-versions
branch
4 times, most recently
from
7960ba5 to
27d86f1
Compare
m-lord-renkse
force-pushed
the
bump-to-latest-versions
branch
from
27d86f1 to
1ed9483
Compare
Bump crates to the latest versions