Sepolia deployment #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh2smith
approved these changes
Nov 20, 2023
| @@ -12,5 +12,6 @@ mainnet = "https://mainnet.infura.io/v3/${INFURA_KEY}" | |||
| rinkeby = "https://rinkeby.infura.io/v3/${INFURA_KEY}" | |||
There was a problem hiding this comment.
This could probably be removed here as well. Rinkeby died.
There was a problem hiding this comment.
Created an issue for this so git commit remain aligned.
mfw78
approved these changes
Nov 21, 2023
| @@ -12,5 +12,6 @@ mainnet = "https://mainnet.infura.io/v3/${INFURA_KEY}" | |||
| rinkeby = "https://rinkeby.infura.io/v3/${INFURA_KEY}" | |||
There was a problem hiding this comment.
Created an issue for this so git commit remain aligned.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes needed to deploy on Sepolia and new deployments.
I used Uniswap's WETH on Sepolia for this deployment (0xfFf9976782d46CC05630D1f6eBAb18b2324d6B14).
The format of the deployment file has slightly changed (in the better imho): I didn't edit it in any way except for renaming the file to match this repo structure (
run-latest.jsontodeployment.*.json).We don't use deterministic deployments, so the new contracts are at a different address compared to our previous deployments.
I changed the gitignore because otherwise the new deployment files were ignored.
I also added a CODEOWNER file in a previous commit, since it's a small change I decided to add it to this PR, so that the commit in the deployment file matches the actual commit in this PR.
Test plan
Check the verified contracts on Etherscan: