Clippy

src/configuration.rs

@@ -59,8 +59,9 @@ impl Configuration {
     }
 }
 
+#[allow(dead_code)]
 fn collect_required_environment_variable(key: &str) -> Result<String> {
-    Ok(env::var(key).context(format!("required environment variable {} not set", key))?)
+    env::var(key).context(format!("required environment variable {} not set", key))
 }
 
 fn collect_optional_environment_variable(key: &str) -> Result<Option<String>> {

src/cow_api_client.rs

@@ -90,6 +90,7 @@ impl CowAPIClient {
         })
     }
 
+    #[allow(clippy::too_many_arguments)]
     pub async fn create_order(
         &self,
         order_contract: Address,

src/encoder.rs

@@ -4,6 +4,7 @@ use hex::FromHex;
 
 use crate::constants::{APP_DATA, ERC20_BALANCE, KIND_SELL};
 
+#[allow(clippy::too_many_arguments)]
 pub fn get_eip_1271_signature(
     from_token: Address,
     to_token: Address,

src/ethereum_client.rs

@@ -66,6 +66,7 @@ impl EthereumClient {
             .map(|block_num: U64| block_num.try_into().unwrap()) // U64 -> u64 should always work
     }
 
+    #[allow(dead_code)]
     pub async fn get_chain_timestamp(&self) -> Result<u64> {
         Ok(self.get_latest_block().await?.timestamp.as_u64())
     }
@@ -234,7 +235,7 @@ mod tests {
             .await
             .expect("Unable to get requested swaps");
 
-        assert!(requested_swaps.len() > 0);
+        assert!(!requested_swaps.is_empty());
     }
 
     #[test]

src/main.rs

@@ -82,7 +82,7 @@ async fn main() {
             }
         };
 
-        if requested_swaps.len() > 0 {
+        if !requested_swaps.is_empty() {
             info!(
                 "Found {} requested swaps between blocks {} and {}",
                 requested_swaps.len(),