Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
# Description Solvers already submit self computed fee amounts even for orders that still work with a protocol specified fee (e.g. market orders). See this barter response for instance: http://jsonblob.com/1164883806913421312 The code currently rejects those solutions with "invalid trade execution" errors. This PR makes the legacy adapter compliant with the current system where we ignore the fee_amount for orders that don't require them (rather than erroring if it specified) # Changes - Instead of erroring when a surplus fee is specified although the solver doesn't determine the fee we now always use the protocol fee instead - adjust unit test to demonstrate the response is now accepted ## How to test Unit test Fixes #1996
- Loading branch information