Skip to content

Commit

Permalink
Remove crates vscode extension dependency from devcontainer (#3132)
Browse files Browse the repository at this point in the history
# Description
Devcontainer json definition file contains vscode extension dependency:
`crates` which is deprecated. As this extension is only an utility for
checking `Cargo.toml` dependency creates versions and is not needed for
devcontainer to work on our codebase, we decided to drop that extension
from our devcontainer json definition file.
Anyone can still use `crates` or similar extension (like `dependi`) in
devcontainer by installing it locally in vscode.
Reference discussion:
[link](https://cowservices.slack.com/archives/C0375NV72SC/p1731961303020439)

# Changes
Updated `devcontainer.json` file.

## How to test
Open vscode from `services` folder and on popup window click option
"Open in devcontainer" (docker daemon is required to operate). Wait for
containers setup and validation by rust analyzer.
  • Loading branch information
mstrug authored Nov 20, 2024
1 parent be06e4f commit ee4a8ab
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@
]
},
"extensions": [
"rust-lang.rust-analyzer",
"serayuzgur.crates"
"rust-lang.rust-analyzer"
]
}
},
Expand Down

0 comments on commit ee4a8ab

Please sign in to comment.