Fix url splitting #1989
Merged
Fix url splitting #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging early since this is needed for enabling API keys for one of the solvers and makes managing our current infra config easier. |
fleupold
reviewed
Oct 19, 2023
| /// Path that were split like this can be joined to the original URL using | ||
| /// [`join`]. | ||
| pub fn split_at_path(url: &Url) -> Result<(Url, String)> { | ||
| let base = format!( |
There was a problem hiding this comment.
nit: If I'm not mistaken, this should be the same as url.origin().unicode_serialization
https://docs.rs/url/latest/url/struct.Url.html#method.origin
There was a problem hiding this comment.
Was looking for something like this but couldn't find it. 👍
The idea was to have the legacy wrapper just be a wrapper and not require changes for a component we are phasing out anyway. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1988
Changes
Added a helper function to split a URL into base and path which is used for the
legacysolver adapter.How to test
added a unit test