Add block number to simulation error #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunce86
commented
Nov 14, 2023
| @@ -224,6 +224,9 @@ impl Competition { | |||
| tracing::warn!(block = block.number, ?err, "solution reverts on new block"); | |||
| *score_ref = None; | |||
| *self.settlement.lock().unwrap() = None; | |||
| if let Some(id) = settlement.notify_id() { | |||
There was a problem hiding this comment.
Here we have IF because we decided to not send the notifications for merged solutions. While this is okkish now since external solvers are sending a single solution anyway, it may become problematic in the future with combinatorial auctions...
MartinquaXD
approved these changes
Nov 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2018
Changes
web3.notifycallsnotify::simulation_failureas it is important enough to have it's own function