Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settlement merge flag #2460

Closed
wants to merge 5 commits into from

Conversation

nuts-rice
Copy link

Description

Addresses #2418 by a flag in driver config file as well as checks for settlement merge from solver

  • skip-merge value in config file
  • member functions for checking config value
  • checks if should merge solutions or skip merge using Fetch or Skip
  • flags if solution is MergeSkippable or not

How to test

  1. Should be possible to skip merging solution when driver is flagged to Skip
  2. Should be impossible to skip merging solution when driver is flagged to Fetch

Copy link

github-actions bot commented Mar 1, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@nuts-rice
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@sunce86
Copy link
Contributor

sunce86 commented Mar 8, 2024

Dependent on #2471

I suggest first merging the ☝️ and then continue.

Copy link

This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed.

@github-actions github-actions bot added the stale label Mar 16, 2024
@nuts-rice nuts-rice closed this Mar 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants