[EASY] Remove score cap #2577
Merged
[EASY] Remove score cap #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleupold
approved these changes
Mar 29, 2024
| @@ -249,7 +249,7 @@ impl Settlement { | |||
| mempools::RevertProtection::Disabled => gas_cost, | |||
| }; | |||
| let score = competition::Score::new( | |||
| auction.score_cap(), | |||
| competition::Score(eth::U256::MAX.try_into().unwrap()), | |||
There was a problem hiding this comment.
Maybe it makes sense to remove this Score think in this PR as well?
There was a problem hiding this comment.
The code change becomes too large then and hard to review. Planned to do it as part of #2493
MartinquaXD
approved these changes
Mar 29, 2024
squadgazzz
approved these changes
Mar 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2506
How to test
Existing tests.