Isolate Settlement Encoding logic #2632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to move the settlement encoding logic from the boundar module/legacy solver crate into the domain it helps to first isolate the call to encode into a single place. This will then allow us to wrap this invocation behind a conditional config variable to control the rollout (once implemented)
Changes
boundary::Settlementondomain::Settlementstore a struct that referencesdomain::eth::Txdirectly (one for internalized interactions, one for uninternalised interactions repr)settlement.boundary(most of them are already exposed on the solution directly)How to test
CI
Related Issues
First step of #2215