[TRIVIAL] Do not run forked-node tests for external contributions #3201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinquaXD
reviewed
Jan 2, 2025
I didn't, actually. I just searched for the same code on GitHub, and it is being used in many repos for the same purpose. A proper test requires creating a new account. IMO, it is fine to go as it is. |
MartinquaXD
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
How did you verify that this works?
I didn't, actually. I just searched for the same code on GitHub, and it is being used in many repos for the same purpose. A proper test requires creating a new account. IMO, it is fine to go as it is.
Okay, I found this which is enough for me. 👌
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid confusion when forked-node tests fail on external contributor PRs due to the absence of access to some secrets, let's avoid running this job on forked repos.