Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No service fee on penalties #424

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

fhenneke
Copy link
Collaborator

@fhenneke fhenneke commented Nov 8, 2024

With this PR, if a solver receives a negative reward for an accounting week, that amount is not multiplied by reward_scaling.

Before the change, negative rewards were multiplied by reward_scaling independent of the sign of the reward. For positive rewards, this does what it should, as a fraction of the reward is withheld from the solver and becomes part of a bounty budget. For negative rewards, the calculation implied that part of the penalty is withheld and it reduces the bounty budget.

With the change, negative batch rewards are not multiplied by reward_scaling. Quote rewards are left as is.

The proposed implementation changes some code in 3 places. Ideally there would only be one change required. Note, that quote rewards are always non-negative and no change in the formula is required.

Alternatively, the total cow reward could be used to decide on the scaling, instead of handling batch and quote rewards separately.

Tests have not been adapted yet.

@fhenneke fhenneke mentioned this pull request Nov 8, 2024
Base automatically changed from service_fee_log to main November 11, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants