Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info in slack message #475

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Add more info in slack message #475

merged 7 commits into from
Jan 10, 2025

Conversation

harisang
Copy link
Contributor

@harisang harisang commented Dec 24, 2024

This PR adds a bit more info in the final logging messages.

PR #474 needs to be merged first, so marking as draft for now

This PR addresses issue #472

src/fetch/transfer_file.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@fhenneke fhenneke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like us to stick to the convention to pass all config via the AccountingConfig object.

@harisang harisang marked this pull request as ready for review January 9, 2025 16:14
@harisang harisang force-pushed the improve_slack_log_message branch from 94b4b02 to 35bf37e Compare January 10, 2025 15:04
@fhenneke fhenneke merged commit 5959eaf into main Jan 10, 2025
6 checks passed
@fhenneke fhenneke deleted the improve_slack_log_message branch January 10, 2025 15:28
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants