Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Matchstick Tests #56

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Added Matchstick Tests #56

wants to merge 16 commits into from

Conversation

GabrielCamba
Copy link
Contributor

@GabrielCamba GabrielCamba commented Aug 8, 2022 •
edited
Loading

This PR adds matchstick tests.

The documentation about this is included on a tests.md file and linked on the readme file.

As explained there are 3 types of tests:

  1. Gpv2Settlement: currently tested Trades and Tokens creation
  2. GC: Checked price obtained for xDAI token
  3. Mainnet: Did some tests about bundle and pool creation

Tests

@GabrielCamba GabrielCamba added Subgraph Subgraph related task Protofire labels Aug 8, 2022
@GabrielCamba GabrielCamba self-assigned this Aug 8, 2022
@GabrielCamba GabrielCamba marked this pull request as ready for review September 27, 2022 12:30
@GabrielCamba
Added missing information about creating subgraph.yaml file.
bc19a1f 
Added missing information about creating subgraph.yaml file before running the tests.
@GabrielCamba
Added subgraph.yaml creation to all tests
dc68654
alfetopito
alfetopito reviewed Oct 7, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
alfetopito
alfetopito reviewed Oct 21, 2022
View reviewed changes
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Now just need to fix the issue running the tests. Are you doing it in this PR?

@GabrielCamba
Copy link
Contributor Author

Nice!

Now just need to fix the issue running the tests. Are you doing it in this PR?

Yes sir! I'll let you know as soon as it's done. ;)

@GabrielCamba
Copy link
Contributor Author

Already fixed and ready for review!

alfetopito
alfetopito requested changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is still missing, the tests are failing.

Just pulled the latest:

Screen Shot 2022-10-26 at 10 04 55

Even after running yarn codegen the test fails:

Screen Shot 2022-10-26 at 10 09 35

If I try to build I get a similar error:

Screen Shot 2022-10-26 at 10 07 36

One more thing that I noticed, the same generateConfigs command is used for all networks, although it's hardcoded to mainnet.
Wouldn't that be a problem for GC for example?
Screen Shot 2022-10-26 at 10 10 51

@GabrielCamba
Copy link
Contributor Author

One more thing that I noticed, the same generateConfigs command is used for all networks, although it's hardcoded to mainnet. Wouldn't that be a problem for GC for example?

yes, the error was there. I needed to use the gc config and run the codegen command before running the tests. I already had those files generated, that's why I didn't face that error.
Can you please test it again?

alfetopito
alfetopito approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Got all tests running and passing locally 👍

package.json Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramirotw ramirotw ramirotw approved these changes

@alfetopito alfetopito alfetopito approved these changes

@anxolin anxolin Awaiting requested review from anxolin

Assignees

@GabrielCamba GabrielCamba

Labels
Protofire Subgraph Subgraph related task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GabrielCamba @alfetopito @ramirotw