Fix issue with missing topics #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR closes #68.
It also adds a test for the block which broke the script.
At the moment the test should fail due to a missing node url secret.Tests are using a public MEV blocker RPC now and seem to pass. I had to work around the unusual setup of the data fetcher which requires the existence of of a sleep environment variable even though that variable is not needed for fetching blockchain data.
To check that the change actually changes behavior, you can comment out the changed line locally and then run the test via
pytest tests/e2e/test_blockchain_data.py. It should fail without the change and pass with the change.