chore: rename some metrics #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anxolin
commented
Oct 10, 2023
| @@ -21,7 +21,7 @@ import { | |||
| } from "../utils"; | |||
| import { | |||
| blockHeight, | |||
| blockTime, | |||
| blockProducingRate, | |||
There was a problem hiding this comment.
producing, production?
anxolin
commented
Oct 10, 2023
| @@ -46,20 +46,20 @@ export const blockHeight = new client.Gauge({ | |||
| }); | |||
|
|
|||
| export const reorgDepth = new client.Gauge({ | |||
| name: "watch_tower_reorg_depth", | |||
| help: "Depth of the current reorg", | |||
| name: "watch_tower_latest_reorg_depth", | |||
There was a problem hiding this comment.
if find this more clear
anxolin
commented
Oct 10, 2023
| labelNames: ["chain_id"], | ||
| }); | ||
|
|
||
| export const blockTime = new client.Gauge({ | ||
| name: "watch_tower_block_time_seconds", | ||
| export const blockProducingRate = new client.Gauge({ |
There was a problem hiding this comment.
block time i would expect the latest epoc there, with this i try to show that it tracks the producing rate
anxolin
commented
Oct 10, 2023
| help: "Time since last block", | ||
| labelNames: ["chain_id"], | ||
| }); | ||
|
|
||
| export const eventsProcessedTotal = new client.Counter({ | ||
| name: "watch_tower_events_processed_total", | ||
| help: "Total number of events processed", | ||
| name: "watch_tower_order_creation_events_total", |
There was a problem hiding this comment.
events might be too generic. Its good to specify imo
anxolin
commented
Oct 10, 2023
src/utils/metrics.ts
Outdated
| export const newContractsTotal = new client.Counter({ | ||
| name: "watch_tower_new_contracts_total", | ||
| help: "Total number of new contracts", | ||
| export const contractsTotal = new client.Counter({ |
There was a problem hiding this comment.
i don't love the previous nor the new suggestion.
I feel the contractsTotal is also a bit generic.
maybe conditional_order_owners_total is nicer?
There was a problem hiding this comment.
Actually i will change this in the PR (my first suggestion was watch_tower_contracts_total)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I just reviewed the names of the metrics again and they look great. With these ones, we have more than enough. Great job.
This PR suggests changing some naming on only a few of them