Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration file #131
Configuration file #131
Changes from all commits
39884ee
6637318
c0b8f79
9267ede
ba79855
3263da1
c064848
7730d96
e7bda59
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not from this PR, I would start saying with what it is and not what it requires.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about something in these lines:
The programatic orders allow you to automatically place unlimited order, following your arbitrary trading strategy defined using the programmatic order frameworks.
Because smart contracts can't place orders in the Orderbook API, you will need a Watch-Tower that monitors these contracts and places an order on your behalf.
This project contains a general-purpose watch tower that will monitor all or some specific accounts, or orders depending on configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While nice, the idea is mostly that there is a hyperlink there that explains it, and reduces duplication of typing / explanation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is nicer indeed. But now we have an hybrid of envs and config.
Shouldn't we add all the config in the config file if we just made it mandatory to add one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, I don't have a strong opinion either way on this, and only did this way so as to minimise work, and minimise type duplication between the
watch-tower
and the Pulumi configuration for infrastructure (not a strong argument though).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this necesary in this PR? now is ok, but feels like could be done in a different PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we want to remove these features?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runMulti
has been superceded (actually,run
was removed andrunMulti
was repurposed torun
).replayBlock
andreplayTx
weren't actually implemented (so removed dead stubs).This file was deleted.
This file was deleted.
This file was deleted.