Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional order id to our model #145

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Add conditional order id to our model #145

merged 4 commits into from
Feb 14, 2024

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Feb 14, 2024

Description

Ths PR adds the conditional order ID to our mode.

As this is a breaking change, the PR also does some model migration (from version 1 to version 2).

Additionally, it adds some additional logging to print the conditional order ID which is convenient.

@anxolin anxolin changed the title Add order Add conditional order id to our model Feb 14, 2024
@anxolin anxolin marked this pull request as ready for review February 14, 2024 16:42
Copy link
Contributor

@mfw78 mfw78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One to be aware of, in the future (or even possible with TWAP), the conditionalOrderId is not unique and can result in interesting issues when searching via logs.

@anxolin anxolin merged commit b1a8b5a into main Feb 14, 2024
4 checks passed
@anxolin anxolin deleted the add-order-id branch February 14, 2024 17:20
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants