chore: add more logs for OOM search #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
anxolin
reviewed
Dec 3, 2024
anxolin
reviewed
Dec 3, 2024
anxolin
reviewed
Dec 3, 2024
anxolin
reviewed
Dec 3, 2024
anxolin
reviewed
Dec 3, 2024
anxolin
reviewed
Dec 3, 2024
src/types/model.ts
Outdated
| @@ -95,27 +96,32 @@ export interface RegistryBlock { | |||
| hash: string; | |||
| } | |||
|
|
|||
| type OrdersPerOwner = Map<Owner, Set<ConditionalOrder>>; | |||
|
|
|||
| const logger = getLogger("Registry"); | |||
There was a problem hiding this comment.
Why registry if this is in model.ts?
There was a problem hiding this comment.
I have no idea :)
I just moved it from class in order to use in loadOwnerOrders()
There was a problem hiding this comment.
Its a similar comment as above. You took it out of the registry and has still a very generic name.
I don't think getting loggers should be the memory leak (i hope)
There was a problem hiding this comment.
Got you.
Created a separate logger:
const loadOwnerOrdersLogger = getLogger("loadOwnerOrders");
anxolin
reviewed
Dec 3, 2024
anxolin
approved these changes
Dec 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code doesn't change the logic, it only adds more logs and refactors the code a bit.
The last point is my suspect. I assume that comparation here is not valid, we should not use shallow comparison for the objects.