Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show id of order and tx hash when posting the discrete order #169

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Dec 3, 2024

Description

This PR is the most pressing change in the proposal to improve debuggability of watch-tower described in https://docs.google.com/document/d/1rNM4pqS-d17Yx1Ei_RMMvER5vJfK1c8I7Ik74PbOHSc/edit?tab=t.0

Basically, this PR allows us to connect the discrete orders with the programmatic order that created them. This is really important, because we can connect some issues on some orders that are wrongly created by a smart contract, with the smart contract that created them in the first place.

@anxolin anxolin requested review from shoom3301 and a team December 3, 2024 21:59
@anxolin anxolin merged commit dbb2a8c into main Dec 5, 2024
4 checks passed
@anxolin anxolin deleted the connect-discrete-orders-and-programmatic-orders branch December 5, 2024 18:50
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants