Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory leak #99

Merged
merged 3 commits into from
Oct 11, 2023
Merged

fix: memory leak #99

merged 3 commits into from
Oct 11, 2023

Conversation

mfw78
Copy link
Contributor

@mfw78 mfw78 commented Oct 10, 2023

Description

This PR addresses potential sources of the memory leak that was observed in staging.

Changes

  • Remove express-prometheus-middlware
  • Ensure flushing to leveldb on every block
  • Refactor getLogger to re-use loggers held in the rootLogger within loglevel.

How to test

  1. Deploy to staging infrastructure environment
  2. Observe pod memory consumption remains stable

Related Issues

Fixes #98

@mfw78 mfw78 added the bug Something isn't working label Oct 10, 2023
@mfw78 mfw78 requested review from anxolin and a team October 10, 2023 02:42
@mfw78 mfw78 self-assigned this Oct 10, 2023
@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @types/[email protected], [email protected]

@mfw78 mfw78 marked this pull request as ready for review October 10, 2023 11:45
Base automatically changed from health-probe to main October 10, 2023 11:53
@mfw78 mfw78 merged commit 5bd3e65 into main Oct 11, 2023
3 checks passed
@mfw78 mfw78 deleted the fix-memory-leak branch October 11, 2023 06:50
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: memory leak on gnosis chain
2 participants