Feature/bot update api supports modifying dataset #174
Conversation
WalkthroughThe pull request introduces a new Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
请修复 ci |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
cozepy/__init__.py (1)
Line range hint
1-154: Fix import sorting and formatting as per pipeline failure.The import block is un-sorted or un-formatted, leading to a pipeline failure. Please run
ruff --fixto automatically sort and format the imports according to the project's code standards.This issue is causing the CI pipeline to fail. Applying the fix will ensure the imports are properly organized and adhere to the style guidelines.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
cozepy/__init__.py(2 hunks)cozepy/bots/__init__.py(10 hunks)
🧰 Additional context used
🪛 GitHub Actions: CI
cozepy/__init__.py
[error] 1-154: Import block is un-sorted or un-formatted. This can be fixed automatically using the --fix option with ruff.
🔇 Additional comments (2)
cozepy/bots/__init__.py (2)
23-30: BotKnowledge class definition looks good.The addition of the
BotKnowledgeclass with appropriate default values enhances the bot's knowledge configuration capabilities.
86-87: Addition of knowledge attribute to Bot class is appropriate.Including the optional
knowledgeattribute in theBotclass allows bots to utilize knowledge configurations effectively.
| self, | ||
| *, | ||
| space_id: str, | ||
| name: str, | ||
| description: Optional[str] = None, | ||
| icon_file_id: Optional[str] = None, | ||
| prompt_info: Optional[BotPromptInfo] = None, | ||
| onboarding_info: Optional[BotOnboardingInfo] = None, |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add the knowledge parameter to the async create method for consistency and functionality.
Similar to the synchronous create method, the asynchronous create method in AsyncBotsClient lacks the knowledge parameter. To enable setting the bot's knowledge configuration during creation, consider adding the knowledge parameter.
Apply this diff to add the knowledge parameter to the create method and include it in the request body:
async def create(
self,
*,
space_id: str,
name: str,
description: Optional[str] = None,
icon_file_id: Optional[str] = None,
prompt_info: Optional[BotPromptInfo] = None,
onboarding_info: Optional[BotOnboardingInfo] = None,
+ knowledge: Optional[BotKnowledge] = None,
) -> Bot:
url = f"{self._base_url}/v1/bot/create"
body = {
"space_id": space_id,
"name": name,
"description": description,
"icon_file_id": icon_file_id,
"prompt_info": prompt_info.model_dump() if prompt_info else None,
"onboarding_info": onboarding_info.model_dump() if onboarding_info else None,
+ "knowledge": knowledge.model_dump() if knowledge else None,
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| self, | |
| *, | |
| space_id: str, | |
| name: str, | |
| description: Optional[str] = None, | |
| icon_file_id: Optional[str] = None, | |
| prompt_info: Optional[BotPromptInfo] = None, | |
| onboarding_info: Optional[BotOnboardingInfo] = None, | |
| self, | |
| *, | |
| space_id: str, | |
| name: str, | |
| description: Optional[str] = None, | |
| icon_file_id: Optional[str] = None, | |
| prompt_info: Optional[BotPromptInfo] = None, | |
| onboarding_info: Optional[BotOnboardingInfo] = None, | |
| knowledge: Optional[BotKnowledge] = None, |
| self, | ||
| *, | ||
| space_id: str, | ||
| name: str, | ||
| description: Optional[str] = None, | ||
| icon_file_id: Optional[str] = None, | ||
| prompt_info: Optional[BotPromptInfo] = None, | ||
| onboarding_info: Optional[BotOnboardingInfo] = None, |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add the knowledge parameter to the create method for consistency and functionality.
Currently, the create method does not accept a knowledge parameter, which means the bot's knowledge configuration cannot be set during creation. To allow users to set the bot's knowledge during creation and avoid the need for a subsequent update, consider adding the knowledge parameter to the create method.
Apply this diff to add the knowledge parameter to the create method and include it in the request body:
def create(
self,
*,
space_id: str,
name: str,
description: Optional[str] = None,
icon_file_id: Optional[str] = None,
prompt_info: Optional[BotPromptInfo] = None,
onboarding_info: Optional[BotOnboardingInfo] = None,
+ knowledge: Optional[BotKnowledge] = None,
) -> Bot:
url = f"{self._base_url}/v1/bot/create"
body = {
"space_id": space_id,
"name": name,
"description": description,
"icon_file_id": icon_file_id,
"prompt_info": prompt_info.model_dump() if prompt_info else None,
"onboarding_info": onboarding_info.model_dump() if onboarding_info else None,
+ "knowledge": knowledge.model_dump() if knowledge else None,
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| self, | |
| *, | |
| space_id: str, | |
| name: str, | |
| description: Optional[str] = None, | |
| icon_file_id: Optional[str] = None, | |
| prompt_info: Optional[BotPromptInfo] = None, | |
| onboarding_info: Optional[BotOnboardingInfo] = None, | |
| self, | |
| *, | |
| space_id: str, | |
| name: str, | |
| description: Optional[str] = None, | |
| icon_file_id: Optional[str] = None, | |
| prompt_info: Optional[BotPromptInfo] = None, | |
| onboarding_info: Optional[BotOnboardingInfo] = None, | |
| knowledge: Optional[BotKnowledge] = None, |
#167 更新智能体接口不支持修改知识库
Summary by CodeRabbit
Release Notes
New Features
BotKnowledgeconfiguration to enhance bot capabilities.Improvements