Find apps suggestions in the service #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptbrowne
reviewed
Apr 2, 2019
| @@ -2,6 +2,7 @@ module.exports = function(api) { | |||
| api.cache(true) | |||
|
|
|||
| return { | |||
| sourceType: 'unambiguous', | |||
There was a problem hiding this comment.
Link to doc : https://babeljs.io/docs/en/options#sourcetype
sourceType
Type: "script" | "module" | "unambiguous"
Default: "module"
"script" - Parse the file using the ECMAScript Script grammar. No import/export statements allowed, and files are not in strict mode.
"module" - Parse the file using the ECMAScript Module grammar. Files are automatically strict, and import/export statements are allowed.
"unambiguous" - Consider the file a "module" if import/export statements are present, or else consider it a "script".
On avait quoi comme problème ?
ptbrowne
reviewed
Apr 2, 2019
ptbrowne
reviewed
Apr 2, 2019
| return this.queryAll({ slug }).then(head) | ||
| } | ||
|
|
||
| static linkTransaction(suggestion, transaction) { |
There was a problem hiding this comment.
I don't know why but it seems weird to have link here where the original suggestion is not modified.
ptbrowne
reviewed
Apr 2, 2019
ptbrowne
reviewed
Apr 2, 2019
ptbrowne
reviewed
Apr 2, 2019
ptbrowne
reviewed
Apr 2, 2019
ptbrowne
approved these changes
Apr 5, 2019
ptbrowne
force-pushed
the
konnectors-candidates
branch
from
ea8b923 to
c8cd1d7
Compare
It will be used by service to fetch transactions for which we have to find apps suggestions
We need it in services because we have mixed ES Modules and CommonJS modules. See https://babeljs.io/docs/en/options#sourcetype
When using `bulkSave`, we have "The database could not be created, the file already exists" errors
This way Document from cozy-doctypes automatically add cozyMetadata.createdByApp
ptbrowne
force-pushed
the
konnectors-candidates
branch
from
8b3fab7 to
23e8091
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add a new step to the onOperationOrBillCreate service. In this step, we look for available connectors that the user didn't installed but that can be useful for him, based on his banking transactions.
We create one
io.cozy.apps.suggestionsdocument for each connector we want to suggest. Each of these documents have relationships to the transactions that made us think this connector could be useful for the user.You can find more on the
io.cozy.apps.suggestionsdocumentation.