feat: handle shortcuts in appsections VO-777 #2680

acezard · 2024-08-07T07:42:28Z

Allow shortcuts doctype to be used in AppsSections in cozy-store (previously only konnectors and apps were set up).

react/AppSections/Sections.jsx

react/AppSections/locales/en.json

react/AppTile/index.jsx

cballevre · 2024-08-08T14:13:05Z

react/AppTile/index.jsx

@@ -91,8 +115,10 @@ export const AppTile = ({
        <TileTitle isMultiline={!statusLabel}>
          {namePrefix ? `${namePrefix} ${name}` : name}
        </TileTitle>
-        {developer.name && showDeveloper && (
-          <TileSubtitle>{`${t('app_item.by')} ${developer.name}`}</TileSubtitle>
+        {(developer.name || app.metadata.source) && showDeveloper && (


I would extract developer.name || app.metadata.source in a const and use isShortcut to determine which version I should display. Even if I don't have developer.name on my app I don't want that he search for a source on the file

cballevre · 2024-08-08T14:14:34Z

react/ShortcutTile/index.tsx

+import styles from '../AppTile/styles.styl'
+
+interface ShortcutTileProps {
+  file: {


Maybe you could use the IOCozyFile from cozy-client with partial ?

nit: perso je sortirai les interface dans des fichiers séparés

Pour les interfaces de props je serais plutôt pour les garder dans le même fichier tous comme on garde les propTypes dans le même fichier

alerte sujet sensible vision personnelle 🤣 faudrait qu'on regarde ce qui se fait majoritairement dans l'ecosystème et chez "les grands"...

C'est sur que c'est opiniated et qu'on trouve ce que l'on cherche :

Sentry : example

Grafana : example

Je pense que la discussion des React.FC vs ({ user }: AvatarProps): JSX.Element se pose aussi histoire d'augmenter la cohérence de la base de code mais c'est hors scope de la PR

react/ShortcutTile/index.tsx

package.json

JF-Cozy · 2024-08-13T07:54:24Z

react/ShortcutTile/index.tsx

+import styles from '../AppTile/styles.styl'
+
+interface ShortcutTileProps {
+  file: {


nit: perso je sortirai les interface dans des fichiers séparés

react/ShortcutTile/index.tsx

react/types.d.ts

react/AppTile/AppTile.spec.jsx

JF-Cozy · 2024-08-13T08:05:07Z

react/AppSections/helpers.js

nit: dans ce commit on apporte plusieurs correctif, idéalement on devrait les merger avec les autres commits pour les faire disparaître de celui-ci, ce qui rendrait son intitulé plus juste. Sinon changer l'intituler... on peut laisser comme ça ici, c'était juste pour la remarque.

JF-Cozy · 2024-08-14T12:28:54Z

react/AppSections/Sections.jsx

@@ -230,6 +277,6 @@ Sections.defaultProps = {
  })
 }

-export const Untranslated = withBreakpoints()(Sections)
+export const Untranslated = withBreakpoints()(SectionsWrapper)


on pourrait remplacer withBreakpoints par useBreakpoints au passage ?

Pourquoi utiliser useExtendI18n en plus de withLocales ? Quel problème on résout grâce à generateI18nConfig ?

on reçoit les localisations au runtime, on ne les a pas au moment du build dans cette feature

Vu ensemble, les locales sont dans les flags. Ici on récupère la technique employée sur Store. Il serait plus judicieux de faire un getI18nFromFlag ou un useI18nFromFlag (qui utiliserait useExtendI18n) pour gérer ça plus globalement. Vu l'échéance, on décale ce refacto à une autre PR @acezard

JF-Cozy · 2024-08-14T12:52:47Z

react/Typography/index.d.ts

@@ -0,0 +1,8 @@
+declare module 'cozy-ui/react/Typography' {
+  const component: (props: Record<string, unknown>) => JSX.Element


est-ce qu'on ne pourrait pas lister les vrais props ?

JF-Cozy · 2024-08-14T12:55:24Z

package.json

@@ -101,6 +102,7 @@
    "cozy-logger": "^1.9.0",
    "cozy-sharing": "^14.1.0",
    "cozy-stack-client": "^47.4.0",
+    "cpx": "1.5.0",


question naïve, est-ce qu'on ne peut pas utiliser les mécaniques en place plutôt que d'utiliser une nouvelle approche ? Je te transmets le paper sur le sujet...

JF-Cozy

On sort également de cette PR les sujets d.ts, à faire dans une autre

cozy-bot · 2024-08-14T14:28:31Z

🎉 This PR is included in version 111.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

The properties are adapted only once in the app that consumes the component, to be less specific. This is a revert of a part of the PR : #2680

acezard force-pushed the feat--handle-shortcuts-in-appsections branch 2 times, most recently from 1dd88e5 to 9acf0dc Compare August 7, 2024 13:03

acezard marked this pull request as ready for review August 7, 2024 13:03

acezard requested review from JF-Cozy, Merkur39, Ldoppea and zatteo as code owners August 7, 2024 13:03

JF-Cozy force-pushed the feat--handle-shortcuts-in-appsections branch from fcfb607 to 566eae9 Compare August 7, 2024 14:45

acezard requested a review from cballevre August 8, 2024 07:36

cballevre reviewed Aug 8, 2024

View reviewed changes

JF-Cozy reviewed Aug 13, 2024

View reviewed changes

acezard force-pushed the feat--handle-shortcuts-in-appsections branch from 6be1d6e to 5388b63 Compare August 13, 2024 08:18

acezard changed the base branch from master to feat--update-lint-config August 13, 2024 08:18

acezard force-pushed the feat--handle-shortcuts-in-appsections branch 6 times, most recently from ec930c7 to 393b373 Compare August 13, 2024 12:55

acezard requested review from JF-Cozy and cballevre August 13, 2024 13:19

acezard force-pushed the feat--update-lint-config branch 2 times, most recently from 59a8994 to 24d5571 Compare August 14, 2024 12:56

JF-Cozy reviewed Aug 14, 2024

View reviewed changes

acezard force-pushed the feat--handle-shortcuts-in-appsections branch 2 times, most recently from 60b6a82 to cdf8681 Compare August 14, 2024 13:10

JF-Cozy approved these changes Aug 14, 2024

View reviewed changes

acezard force-pushed the feat--handle-shortcuts-in-appsections branch from cdf8681 to 754bdf6 Compare August 14, 2024 13:16

Base automatically changed from feat--update-lint-config to master August 14, 2024 13:17

acezard force-pushed the feat--handle-shortcuts-in-appsections branch from 754bdf6 to d655aa7 Compare August 14, 2024 13:17

acezard force-pushed the feat--handle-shortcuts-in-appsections branch 2 times, most recently from 9eda84f to 2e92b27 Compare August 14, 2024 13:39

feat: handle shortcuttiles

fa3a753

acezard force-pushed the feat--handle-shortcuts-in-appsections branch from 2e92b27 to fa3a753 Compare August 14, 2024 13:40

acezard merged commit e5ff800 into master Aug 14, 2024
5 checks passed

acezard deleted the feat--handle-shortcuts-in-appsections branch August 14, 2024 14:04

cozy-bot added the released label Aug 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: handle shortcuts in appsections VO-777 #2680

feat: handle shortcuts in appsections VO-777 #2680

acezard commented Aug 7, 2024 •

edited

Loading

cballevre Aug 8, 2024

cballevre Aug 8, 2024

JF-Cozy Aug 13, 2024

cballevre Aug 13, 2024

JF-Cozy Aug 14, 2024

cballevre Aug 14, 2024 •

edited

Loading

JF-Cozy Aug 13, 2024

JF-Cozy Aug 13, 2024

JF-Cozy Aug 14, 2024

acezard Aug 14, 2024

JF-Cozy Aug 14, 2024

JF-Cozy Aug 14, 2024

JF-Cozy Aug 14, 2024

JF-Cozy left a comment

cozy-bot commented Aug 14, 2024

		@@ -0,0 +1,8 @@
		declare module 'cozy-ui/react/Typography' {
		const component: (props: Record<string, unknown>) => JSX.Element

feat: handle shortcuts in appsections VO-777 #2680

feat: handle shortcuts in appsections VO-777 #2680

Conversation

acezard commented Aug 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cballevre Aug 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JF-Cozy left a comment

Choose a reason for hiding this comment

cozy-bot commented Aug 14, 2024

acezard commented Aug 7, 2024 •

edited

Loading

cballevre Aug 14, 2024 •

edited

Loading