Fix UnicodeDecodeError error when sending digests #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Case CPANEL-46529 If a digest contained a message that had non-utf8 characters, sending the digest would fail with a UnicodeDecodeError. We now check the messages characterset and use that to decode the message into a string.
cpanel-jared
force-pushed
the
hb_integration
branch
from
5387169 to
ec25c17
Compare
Case CPANEL-46556
Decode rather than encoding before sending adminsubscribeack.txt email. Previously, an effort was made to encode the member's name in the appropriate charset before passing it to formataddr(). Now, this is wrong, and we actually need to ensure that it is *not* encoded yet. What gets passed into formataddr() must be str, not bytes. It's possible for name to be either str or bytes depending on which version of Mailman + Python saved the info to disk previously, so we still need to check which it is before attempting to decode. This only applies to 'nameu' because 'email' never got this special encoding treatment.
CPANEL-46551
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case CPANEL-46529
If a digest contained a message that had non-utf8 characters, sending the digest would fail with a UnicodeDecodeError. We now check the messages characterset and use that to decode the message into a string.