-
Notifications
You must be signed in to change notification settings - Fork 716
Add get
and write
HealthData by UUID method
#1165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update README file - Update example app to show health point detail on the bottom sheet dialog - Adjust fetch data loading indicator sizing
- Add breaking changes section - Update writeHealthData usage example
Based on this issue #1139, I have updated Kindly review and make additional changes if required. Please let me know if we need/have different approaches to achieve this goal. |
get
and write
HealthData by UUID method
Thanks for the PR! I was actually trying to make this after I saw #1139. |
The start and end time is for Android only as they do not expose any API to get a single record by uuid, so I'm using tiniest time range to get small amount of records then find it by uuid. however, start and end time will not be used for iOS as it only needs to pass uuid and type to get a single record. |
In health connect there is two ways to read
|
oh my bad I wasn't aware of it. I can switch to that method instead |
- Remove start and end time on native methods - Android: change readRecords() to readRecord() - Update inline documentation on health_plugin - Update README - Example: remove startTime from fetchDataByUUID method - Add an ability to openDetailBottomSheet onLongPress with existing HealthDataPoint for preview purpose
@iarata I'm afraid I couldn't make any changes on this branch (on forked repo) as I'm using it for production. I will instead create a new branch for iOS and Android for this implementation and sync with Edit: I will also separate the |
Note: both Swift and Kotlin codes to
getDataByUUID
is copied fromgetData
and modified to return an single record instead of list.