Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds initial draft for separate compilation #96

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

VictorEijkhout
Copy link
Contributor

First attempt at "separate compilation" module.

@vulder vulder requested review from vulder and jcvw October 2, 2024 07:00
Copy link
Collaborator

@vulder vulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice first draft for the separate compilation topic.

Most of my comments are just align syntax/file structure with the rest of the topics. Overall, this topic highlights already many important points about the topic.

sources/modules/compilation-model/separate-compilation.md Outdated Show resolved Hide resolved
sources/modules/compilation-model/separate-compilation.md Outdated Show resolved Hide resolved
sources/modules/compilation-model/separate-compilation.md Outdated Show resolved Hide resolved
sources/modules/compilation-model/separate-compilation.md Outdated Show resolved Hide resolved
sources/modules/compilation-model/separate-compilation.md Outdated Show resolved Hide resolved
sources/modules/compilation-model/separate-compilation.md Outdated Show resolved Hide resolved
sources/modules/compilation-model/separate-compilation.md Outdated Show resolved Hide resolved
sources/modules/compilation-model/separate-compilation.md Outdated Show resolved Hide resolved
sources/modules/compilation-model/separate-compilation.md Outdated Show resolved Hide resolved
#### Points to cover

1. Cover the mechanisms for include and library paths to your own code, as well as discovery mechanisms for external libraries.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From reading the ASBATs, we probably need more points to cover that contain the skills necessary to reach the ASBAT level.

@diehlpk
Copy link
Contributor

diehlpk commented Oct 21, 2024

refs #8

intro text moved to motivation
remove mention of text editor
turn enum list into item
remove incorrect sentence
TOC in sync with captions
added sentence about translation units
extern variable mention removed
@diehlpk
Copy link
Contributor

diehlpk commented Oct 31, 2024

@vulder and @ronchaine we did a pass in today's meeting. Please have a look.

@vulder vulder self-requested a review November 4, 2024 19:25
@vulder vulder changed the title please merge: separate compilation Adds initial draft for separate compilation Nov 4, 2024
Copy link
Collaborator

@vulder vulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm mark the topic tentative ready and put it on the agenda for the next online SG20 meeting.

guidance where one can continue to investigate this topic in more depth._

* Language inter-operability: the `extern "C"` mechanism.
* Linker conventions including name mangling.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Linker conventions including name mangling.
* Linker conventions including name mangling.

@vulder vulder added the Tentatively ready Ready for a final review in SG20 label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tentatively ready Ready for a final review in SG20
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants