Merge 2024-11 LWG Motion 18 - P1928R15 std::simd — merge data-parallel types from the Parallelism TS 2 #7437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That needs at least careful scrutiny why they would be necessary. Please fix the commit title and message according to https://github.com/cplusplus/draft/wiki/Commit-message-format |
jensmaurer
requested changes
Nov 24, 2024
| \end{note} | ||
|
|
||
| \pnum | ||
| The set of \defn{vectorizable types} comprises all standard integer types, |
There was a problem hiding this comment.
Please use \defnadjx so that we get index entries for both "vectorizable type" and "type, vectorizable".
| \tcode{std::float64_t} are vectorizable types if defined ([basic.extended.fp]). | ||
|
|
||
| \pnum | ||
| The term \defn{data-parallel type} refers to all enabled specializations of |
|
|
||
| \pnum | ||
| The term \defn{data-parallel type} refers to all enabled specializations of | ||
| the \tcode{basic_simd} and \tcode{basic_simd_mask} class templates. A \defn{data-parallel object} is |
| \pnum | ||
| The term \defn{data-parallel type} refers to all enabled specializations of | ||
| the \tcode{basic_simd} and \tcode{basic_simd_mask} class templates. A \defn{data-parallel object} is | ||
| an object of \term{data-parallel type}. |
There was a problem hiding this comment.
Defined phrases are italicized once when defined, and not when referred to. Please remove \term here.
| The elements in a data-parallel type are indexed from 0 to $\textrm{width} - 1$. | ||
|
|
||
| \pnum | ||
| An \defn{element-wise operation} applies a specified operation to the elements of one or more |
|
|
||
| \pnum | ||
| Given a \tcode{basic_simd_mask<Bytes, Abi>} object \tcode{mask}, the | ||
| \defn{selected indices} signify the integers $i$ in the range |
| Given a \tcode{basic_simd_mask<Bytes, Abi>} object \tcode{mask}, the | ||
| \defn{selected indices} signify the integers $i$ in the range | ||
| \range{0}{mask.size()} for which \tcode{mask[$i$]} is \tcode{true}. | ||
| Given a data-parallel object \tcode{data}, the \defn{selected elements} signify the elements |
| \defn{value-preserving} if | ||
| all possible values of \tcode{U} can be represented with type \tcode{T}. | ||
|
|
||
| \rSec2[simd.expos]{Exposition only types, variables, and concepts} |
There was a problem hiding this comment.
Suggested change
| \rSec2[simd.expos]{Exposition only types, variables, and concepts} | |
| \rSec2[simd.expos]{Exposition-only types, variables, and concepts} |
|
Ah whatever GitHub. I renamed the branch to match https://github.com/cplusplus/draft/wiki/Commit-message-format. I'll open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7430
Fixes cplusplus/papers#670
This is still work-in-progress. Several overfull hboxes to be fixed. Also, I assume the local use of
\newcommandmacros is not something I should keep, yes?