Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent Function Label Naming for Sections #7483

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Benio101
Copy link

@Benio101 Benio101 commented Dec 12, 2024

Make [print.fun] consistent with other label names.

🔗 https://isocpp.org/files/papers/P3539R1.pdf

@Benio101
Copy link
Author

Benio101 commented Dec 12, 2024

If I should make a P version of paper instead of github PR, please, let me know.

@jensmaurer
Copy link
Member

Label naming is entirely editorial, although we tend to avoid changing label names without consulting with CWG or LWG. Please don't spend paper numbers on such matters unless directed to do so by the Project Editor. You can easily present the consistency argument in the pull request description inline instead of requiring me to click on a PDF link.

@jwakely , any concerns about the label rename here?

@jensmaurer
Copy link
Member

(And now that you've invested in a paper number, do make sure it appears as a P paper in the next mailing; allocating paper numbers without publishing the corresponding paper isn't helpful either.)

@jensmaurer
Copy link
Member

Please add a \movedxref to xrefdelta.tex:

2024-12-12T13:38:09.4479369Z incorrect entries in xrefdelta.tex:
2024-12-12T13:38:09.4494751Z missing print.fun

(output of checking is accessible via "view raw logs")

@jensmaurer jensmaurer added changes requested Changes to the wording or approach have been requested and not yet applied. and removed changes requested Changes to the wording or approach have been requested and not yet applied. labels Dec 12, 2024
@jensmaurer
Copy link
Member

Thanks. Now, please read https://github.com/cplusplus/draft/wiki/Commit-message-format

squash your commits, adjust the commit message, and force-push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants