Add wording to integrate discussions from p2581r2 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tahonermann
reviewed
Dec 16, 2022
bretbrownjr
reviewed
Dec 16, 2022
tahonermann
reviewed
Dec 16, 2022
buildprocess.tex
Outdated
Comment on lines
20
to
22
| \pnum BMI files can be constructed in a way to optimize for the | ||
| efficiency of the reuse in the import operation, which may result in a | ||
| limitation on the number of scenarios where that file can be used. |
There was a problem hiding this comment.
Suggested change
| \pnum BMI files can be constructed in a way to optimize for the | |
| efficiency of the reuse in the import operation, which may result in a | |
| limitation on the number of scenarios where that file can be used. | |
| \pnum A BMI file can be constructed to optimize for | |
| efficient reuse in an import operation, which may result in a | |
| limitation on the number of scenarios where that file can be used. |
bretbrownjr
reviewed
Dec 16, 2022
tahonermann
reviewed
Dec 16, 2022
| compiler arguments for a BMI file to be used when importing a | ||
| module. When that level of coherency is not met, the translation will | ||
| fail because the BMI cannot be loaded. | ||
|
|
There was a problem hiding this comment.
Suggestion: Examples where ABI and BMI coherency are and are not met would be helpful.
There was a problem hiding this comment.
Created #25 to follow up on this
Co-authored-by: Bret Brown <[email protected]>
Co-authored-by: Bret Brown <[email protected]>
Co-authored-by: Tom Honermann <[email protected]>
bretbrownjr
reviewed
Dec 16, 2022
Co-authored-by: Bret Brown <[email protected]>
|
Approved at the December 16th 2022 meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up using slightly different terms in order to make the text easier to understand. I also had to add a bit of context before talking about the command line arguments.
You can see the rendering with this change reflected in Section 3
Closes: #11
Fixes cplusplus/papers#1241