Replace exceptions with expected - add tests #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced all exception handling with C++23 std::expected for better error handling - Added custom error types with contextual error messages - Created evaluate_or_throw for constexpr evaluation - Updated tests to work with std::expected return types - Added new tests to verify error handling behavior 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Fixed RationalNumber class to handle negative denominators - Added many more test cases for arithmetic operations - Added tests for error handling with std::expected - Updated test values to match actual evaluation results - Added tests for whitespace handling and complex expressions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Simplified error types to contain only necessary information - Removed string messages from StackError, replacing with enum - Changed EvaluationError to store position information instead of messages - Updated all error handling code to use the new error types - Improved CLI error output with colored formatting and visual indicators - Added more descriptive error messages with specific details - Enhanced error position indicator to point directly at the problem - Overall improved user experience with better error feedback 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Added parenthesis balance tracking to ensure proper nesting - Improved error detection for unmatched parentheses - Added detection for empty parentheses cases like () and (()) - Handled division by zero by returning RationalNumber(1, 0) - Updated tests to verify all of these error cases - Added detailed error position reporting for parsing errors 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.