Add 'brotli' package #604
Add 'brotli' package #604
Conversation
docs/packages/pkg/brotli.rst
Outdated
| - `Official <https://github.com/google/brotli>`__ | ||
| - `Hunterized <https://github.com/cpp-pm/brotli>`__ | ||
| - `Example <https://github.com/cpp-pm/hunter/blob/master/examples/brotli/CMakeLists.txt>`__ | ||
| - Added by `drodin <https://github.com/drodin>`__ (`pr-N <https://github.com/cpp-pm/hunter/pull/N>`__) |
cmake/projects/brotli/hunter.cmake
Outdated
| VERSION | ||
| 1.0.9-p0 | ||
| URL | ||
| "https://github.com/drodin/brotli/archive/refs/heads/hunter-1.0.9.zip" |
There was a problem hiding this comment.
@rbsheth please create a fork of https://github.com/google/brotli at https://github.com/cpp-pm/brotli for @drodin to access and use
There was a problem hiding this comment.
There was a problem hiding this comment.
@rbsheth @NeroBurner I don't have access rights to this repo.
There was a problem hiding this comment.
@rbsheth Still can't push a new branch:
remote: error: GH006: Protected branch update failed for refs/heads/hunter-1.0.9.
remote: error: At least 1 approving review is required by reviewers with write access. You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information.
To github.com:cpp-pm/brotli.git
! [remote rejected] hunter-1.0.9 -> hunter-1.0.9 (protected branch hook declined)
There was a problem hiding this comment.
Wow just saw this, sorry @drodin. You can't push to a hunter* branch directly after it has been created, so try pushing to another branch name and creating a PR for review.
There was a problem hiding this comment.
Hi @rbsheth. I want to revive this PR. There was never before a branch hunter* created in this repo. I'm sure that I was able to push to a new hunter* branch in other repos. I was able to push to brunch pr.hunter-1.0.9. What should I choose as a target for a PR if there is no hunter* branch? Can't rename pr.hunter-1.0.9 branch to hunter-1.0.9 as well...
There was a problem hiding this comment.
Hi @drodin, not sure what happened so I made a hunter-1.0.9 branch for you https://github.com/cpp-pm/brotli/tree/hunter-1.0.9
examples/brotli/CMakeLists.txt
Outdated
| # Copyright (c) 2016-2020, Rahul Sheth, Ruslan Baratov | ||
| # All rights reserved. | ||
|
|
||
| cmake_minimum_required(VERSION 3.2) |
There was a problem hiding this comment.
This should probably be replaced with 3.5.
There was a problem hiding this comment.
Yes please use 3.5 otherwise we get deprecation warnings while running this example
| cmake_minimum_required(VERSION 3.2) | |
| cmake_minimum_required(VERSION 3.5) |
drodin
force-pushed
the
pr.brotli
branch
2 times, most recently
from
a237b23 to
c521429
Compare
|
@rbsheth I've updated URLs to point to cpp-pm/brotli. Can we merge this? |
examples/brotli/CMakeLists.txt
Outdated
| # Copyright (c) 2016-2020, Rahul Sheth, Ruslan Baratov | ||
| # All rights reserved. | ||
|
|
||
| cmake_minimum_required(VERSION 3.2) |
There was a problem hiding this comment.
Yes please use 3.5 otherwise we get deprecation warnings while running this example
| cmake_minimum_required(VERSION 3.2) | |
| cmake_minimum_required(VERSION 3.5) |
needs a fork of https://github.com/google/brotli in cpp-pm org
will update to correct URL after
step by step carefully. [Yes]