Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError: Cannot read property 'inlineBetween' of undefined #13

Closed
wil93 opened this issue Nov 3, 2017 · 10 comments
Closed

Comments

@wil93
Copy link

wil93 commented Nov 3, 2017

I can't see the button to add gifs, and I get this in the console:

_plugin-third-party-50d2bd319858511af0888741a3aa50818b679a421faef00a443f413a3b6b4542.js:5 Uncaught TypeError: Cannot read property 'inlineBetween' of undefined
    at _plugin-third-party-50d2bd319858511af0888741a3aa50818b679a421faef00a443f413a3b6b4542.js:5
    at _plugin-third-party-50d2bd319858511af0888741a3aa50818b679a421faef00a443f413a3b6b4542.js:66
(anonymous) @ _plugin-third-party-50d2bd319858511af0888741a3aa50818b679a421faef00a443f413a3b6b4542.js:5
(anonymous) @ _plugin-third-party-50d2bd319858511af0888741a3aa50818b679a421faef00a443f413a3b6b4542.js:66
@cpradio
Copy link
Owner

cpradio commented Nov 3, 2017

inlineBetween doesn't appear anywhere in the source code for this plugin... what version of Discourse and what version of the Plugin are you using?

Also, the plugin works just fine on my sandbox (which is up-to-date)

@wil93
Copy link
Author

wil93 commented Nov 3, 2017

Just updated with ./launcher rebuild app

https://forum.olinfo.it

@cpradio
Copy link
Owner

cpradio commented Nov 3, 2017

Yeah, definitely still works on my sandbox (https://sandbox.cpradio.org/).

What version of the plugin are you running, what other plugins do you have installed?

@wil93
Copy link
Author

wil93 commented Nov 3, 2017

These are the other plugins I have:

          - git clone https://github.com/discourse/docker_manager.git
          - git clone https://github.com/kasperpeulen/discourse-mathjax
          - git clone https://github.com/discourse/discourse-spoiler-alert.git
          - git clone https://github.com/discourse/discourse-solved.git
          - git clone https://github.com/discourse/discourse-tagging.git
          - git clone https://github.com/cpradio/discourse-plugin-replygif.git

What version of the plugin are you running

I think the git master one, I just followed the readme

@cpradio
Copy link
Owner

cpradio commented Nov 3, 2017

Your MathJax plugin is the issue, it is severely out of date.
You need to switch to the official plugin
https://meta.discourse.org/t/discourse-math-plugin/65770

@cpradio
Copy link
Owner

cpradio commented Nov 3, 2017

Also, there is an open issue on the MathJax github repo of the exact error you received
kasperpeulen/discourse-mathjax#43

Switching to the Discourse Official plugin will definitely solve your issue.

@cpradio
Copy link
Owner

cpradio commented Nov 3, 2017

Since you use HTTPS, you need to follow this additional setup, as ReplyGIF doesn't support HTTPS (on its own)
https://github.com/cpradio/discourse-plugin-replygif#https-additional-setup

Unfortunately, that requires yet another rebuild (for the template to take effect).

@wil93
Copy link
Author

wil93 commented Nov 3, 2017

Yes, now everything is working (except for the fact that the gif selector is quite glitchy). Thanks 😄

@wil93 wil93 closed this as completed Nov 3, 2017
@cpradio
Copy link
Owner

cpradio commented Nov 3, 2017

By glitchy, you mean the GIFs keep loading pushing images around for the first few seconds? Yeah, that is expected. It should work flawlessly from here on out though.

@wil93
Copy link
Author

wil93 commented Nov 3, 2017

Yes, also I don't really like that the gifs are still until you "select" them, they should be always moving 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants