Fix Qulice warnings

cqfn · Feb 27, 2024 · 0dbbde9 · 0dbbde9
1 parent 866b577
commit 0dbbde9
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 25 deletions.
diff --git a/...hms/mapping/BottomUpMappingAlgorithm.java → ...algorithms/mapping/BottomUpAlgorithm.java b/...hms/mapping/BottomUpMappingAlgorithm.java → ...algorithms/mapping/BottomUpAlgorithm.java
@@ -45,7 +45,8 @@
  *
  * @since 1.1.0
  */
-class BottomUpMappingAlgorithm {
+@SuppressWarnings("PMD.TooManyMethods")
+class BottomUpAlgorithm {
     /**
      * Set of node hashes.
      */
@@ -96,7 +97,7 @@ class BottomUpMappingAlgorithm {
      * @param left Root node of the 'left' tree
      * @param right Root node of the 'right' tree
      */
-    BottomUpMappingAlgorithm(final Node left, final Node right) {
+    BottomUpAlgorithm(final Node left, final Node right) {
         this.hashes = new AbsoluteHash();
         this.depth = new Depth();
         this.parents = new HashMap<>();
@@ -128,27 +129,7 @@ void execute() {
      * @return Result of mapping
      */
     Mapping getResult() {
-        return new Mapping() {
-            @Override
-            public Node getRight(final Node node) {
-                return BottomUpMappingAlgorithm.this.ltr.get(node);
-            }
-
-            @Override
-            public Node getLeft(final Node node) {
-                return BottomUpMappingAlgorithm.this.rtl.get(node);
-            }
-
-            @Override
-            public Map<Node, Node> getReplaced() {
-                return Collections.unmodifiableMap(BottomUpMappingAlgorithm.this.replaced);
-            }
-
-            @Override
-            public Set<Node> getDeleted() {
-                return Collections.unmodifiableSet(BottomUpMappingAlgorithm.this.deleted);
-            }
-        };
+        return new Result(this);
     }
 
     /**
@@ -362,4 +343,44 @@ private void mapChildrenIfDeleted(final Node before) {
             }
         }
     }
+
+    /**
+     * Mapping result.
+     *
+     * @since 1.1.0
+     */
+    private static final class Result implements Mapping {
+        /**
+         * Structure from which the mapping results can be taken.
+         */
+        private final BottomUpAlgorithm data;
+
+        /**
+         * Constructor.
+         * @param data Structure from which the mapping results can be taken
+         */
+        private Result(final BottomUpAlgorithm data) {
+            this.data = data;
+        }
+
+        @Override
+        public Node getRight(final Node node) {
+            return this.data.ltr.get(node);
+        }
+
+        @Override
+        public Node getLeft(final Node node) {
+            return this.data.rtl.get(node);
+        }
+
+        @Override
+        public Map<Node, Node> getReplaced() {
+            return Collections.unmodifiableMap(this.data.replaced);
+        }
+
+        @Override
+        public Set<Node> getDeleted() {
+            return Collections.unmodifiableSet(this.data.deleted);
+        }
+    }
 }
diff --git a/src/main/java/org/cqfn/astranaut/core/algorithms/mapping/BottomUpMapper.java b/src/main/java/org/cqfn/astranaut/core/algorithms/mapping/BottomUpMapper.java
@@ -35,7 +35,7 @@
 public final class BottomUpMapper implements Mapper {
     @Override
     public Mapping map(final Node left, final Node right) {
-        final BottomUpMappingAlgorithm algorithm = new BottomUpMappingAlgorithm(left, right);
+        final BottomUpAlgorithm algorithm = new BottomUpAlgorithm(left, right);
         algorithm.execute();
         return algorithm.getResult();
     }

diff --git a/src/test/java/org/cqfn/astranaut/core/example/LittleTrees.java b/src/test/java/org/cqfn/astranaut/core/example/LittleTrees.java
@@ -41,7 +41,7 @@
  *
  * @since 1.1.0
  */
-@SuppressWarnings("PMD.ProhibitPublicStaticMethods")
+@SuppressWarnings({"PMD.ProhibitPublicStaticMethods", "PMD.TooManyMethods"})
 public final class LittleTrees {
     /**
      * Private constructor.