Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapper structure and algorithms migration (part 1) #12

Merged
merged 5 commits into from
Feb 8, 2024

Conversation

kniazkov
Copy link
Member

@kniazkov kniazkov commented Feb 2, 2024

Migrating algorithms that map one tree to another tree

@kniazkov kniazkov requested review from Maccimo and pollyvolk February 2, 2024 11:07
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (13fa933) 82.38% compared to head (91af792) 82.98%.
Report is 4 commits behind head on master.

Files Patch % Lines
...tranaut/core/algorithms/mapping/TopDownMapper.java 84.61% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #12      +/-   ##
============================================
+ Coverage     82.38%   82.98%   +0.60%     
- Complexity      191      203      +12     
============================================
  Files            28       31       +3     
  Lines           738      776      +38     
  Branches        111      115       +4     
============================================
+ Hits            608      644      +36     
  Misses           90       90              
- Partials         40       42       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kniazkov kniazkov changed the title Mapper structure and algorithms migration Mapper structure and algorithms migration (part 1) Feb 8, 2024
@kniazkov kniazkov marked this pull request as ready for review February 8, 2024 10:45
@kniazkov
Copy link
Member Author

kniazkov commented Feb 8, 2024

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 8, 2024

@rultor merge

@kniazkov OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 96535f3 into cqfn:master Feb 8, 2024
3 checks passed
@rultor
Copy link
Collaborator

rultor commented Feb 8, 2024

@rultor merge

@kniazkov Done! FYI, the full log is here (took me 6min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants