-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOS-939, MOS-940 #16
MOS-939, MOS-940 #16
Conversation
Fix draft mapping to exclude nodes that already mapped
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16 +/- ##
============================================
- Coverage 87.48% 82.52% -4.96%
- Complexity 296 307 +11
============================================
Files 35 38 +3
Lines 1103 1202 +99
Branches 165 185 +20
============================================
+ Hits 965 992 +27
- Misses 85 152 +67
- Partials 53 58 +5 ☔ View full report in Codecov by Sentry. |
@rultor merge please |
@rultor release, tag is |
First issue: The implemented mapper that is used to build the differential trees does not work very well. In particular, if some node occurs more than once, the mapper may relate some child node, which has not actually changed, to two different nodes.This happens because the topological sorting of nodes is not quite correct.
Second issue: If there are long branches, that is, such subtrees in which many times the next nodes have only one child, the mapper tries to replace entirely such branches, although they can be replaced only partially.