Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOS-939, MOS-940 #16

Merged
merged 5 commits into from
Mar 21, 2024
Merged

MOS-939, MOS-940 #16

merged 5 commits into from
Mar 21, 2024

Conversation

kniazkov
Copy link
Member

@kniazkov kniazkov commented Mar 6, 2024

First issue: The implemented mapper that is used to build the differential trees does not work very well. In particular, if some node occurs more than once, the mapper may relate some child node, which has not actually changed, to two different nodes.This happens because the topological sorting of nodes is not quite correct.

Second issue: If there are long branches, that is, such subtrees in which many times the next nodes have only one child, the mapper tries to replace entirely such branches, although they can be replaced only partially.

kniazkov added 2 commits March 5, 2024 13:53
Fix draft mapping to exclude nodes that already mapped
@kniazkov kniazkov requested a review from pollyvolk March 6, 2024 12:54
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 40.98361% with 72 lines in your changes are missing coverage. Please review.

Project coverage is 82.52%. Comparing base (18c7f43) to head (755d78f).
Report is 7 commits behind head on master.

❗ Current head 755d78f differs from pull request most recent head 544a46d. Consider uploading reports for the commit 544a46d to get more accurate results

Files Patch % Lines
...naut/core/algorithms/mapping/TopDownAlgorithm.java 0.00% 55 Missing ⚠️
...aut/core/algorithms/mapping/BottomUpAlgorithm.java 71.42% 8 Missing and 4 partials ⚠️
...tranaut/core/algorithms/mapping/TopDownMapper.java 0.00% 4 Missing ⚠️
...stranaut/core/algorithms/mapping/DraftMapping.java 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #16      +/-   ##
============================================
- Coverage     87.48%   82.52%   -4.96%     
- Complexity      296      307      +11     
============================================
  Files            35       38       +3     
  Lines          1103     1202      +99     
  Branches        165      185      +20     
============================================
+ Hits            965      992      +27     
- Misses           85      152      +67     
- Partials         53       58       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kniazkov kniazkov marked this pull request as ready for review March 7, 2024 11:00
@kniazkov
Copy link
Member Author

kniazkov commented Mar 7, 2024

@rultor merge please

@rultor
Copy link
Collaborator

rultor commented Mar 7, 2024

@rultor merge please

@kniazkov OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Mar 7, 2024

@rultor merge please

@kniazkov Oops, I failed. You can see the full log here (spent 6min)

@kniazkov kniazkov marked this pull request as draft March 7, 2024 11:15
@kniazkov kniazkov marked this pull request as ready for review March 21, 2024 05:27
@kniazkov kniazkov merged commit c1521ce into cqfn:master Mar 21, 2024
1 check passed
@kniazkov
Copy link
Member Author

@rultor release, tag is 1.1.3

@rultor
Copy link
Collaborator

rultor commented Mar 21, 2024

@rultor release, tag is 1.1.3

@kniazkov OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Mar 21, 2024

@rultor release, tag is 1.1.3

@kniazkov Done! FYI, the full log is here (took me 10min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants