Implemented tcommit.Manager and tcommit.Resource as gRPC services #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way, the year of the header should be changed |
ivanbukhtiyarov
requested changes
Oct 20, 2021
There was a problem hiding this comment.
@askerka Hi! First of all could you check the test logs please? Some tests are failed.
askerka
force-pushed
the
238-tcommit-grpc-services
branch
from
5a28d01 to
a04aeb8
Compare
@ivanbukhtiyarov Hi! The tests are fixed. Please, have a look |
askerka
force-pushed
the
238-tcommit-grpc-services
branch
from
a04aeb8 to
441f408
Compare
For #238 - Implemented `tcommit.Manager` and `tcommit.Resource` as gRPC services, separated service and client packages, added `marshall` package to convert struct between the application and proto definitions, and updated `Finish` and `Begin` client's methods with `marshall` package
askerka
force-pushed
the
238-tcommit-grpc-services
branch
from
441f408 to
20ce599
Compare
|
Fixed the code style issues, added |
ivanbukhtiyarov
approved these changes
Oct 27, 2021
|
@g4s8 There are only two lines that are not relevant: Do you want me to delete them? Could you please guide me on what changes do you think are not relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #238 - Implemented
tcommit.Managerandtcommit.Resourceas gRPC services.Separated service and client packages.
Added
marshallpackage to convert struct between the application and proto definitions.Updated
FinishandBeginclient's methods withmarshallpackage