Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ordering of group and artifact variables #565

Merged
merged 1 commit into from
Jan 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/jpeek/web/Futures.java
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ public Future<Func<String, Response>> apply(final String group,
);
Logger.info(
this, "Finished processing of %s:%s",
artifact, group
group, artifact
);
// @checkstyle IllegalCatchCheck (4 lines)
// @checkstyle AvoidCatchingGenericException (4 lines)
Expand Down
8 changes: 4 additions & 4 deletions src/test/java/org/jpeek/web/FuturesTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,15 @@ void testSimpleScenario() throws Exception {
new Assertion<>(
"Futures returns Response",
new Futures(
(artifact, group) -> input -> new RsPage(
(group, artifact) -> input -> new RsPage(
new RqFake(),
"wait",
() -> new IterableOf<>(
new XeAppend("group", group),
new XeAppend("artifact", artifact)
)
)
).apply("a", "g").get().apply("test"),
).apply("g", "a").get().apply("test"),
new IsNot<>(new IsEqual<>(null))
).affirm();
}
Expand All @@ -62,10 +62,10 @@ void testIgnoresCrashes() throws Exception {
new Assertion<>(
"Futures don't crash",
new Futures(
(artifact, group) -> {
(group, artifact) -> {
throw new UnsupportedOperationException("intended");
}
).apply("a1", "g1").get().apply("test-2"),
).apply("g1", "a1").get().apply("test-2"),
new IsNot<>(new IsEqual<>(null))
).affirm();
}
Expand Down
Loading