Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#222] Ignore comments from .gitignore file #235

Merged
merged 1 commit into from
Jan 19, 2024
Merged

[#222] Ignore comments from .gitignore file #235

merged 1 commit into from
Jan 19, 2024

Conversation

pnatashap
Copy link
Contributor

  1. Lines with # in the beginning of the .gitignore content are ignored
  2. Enable tests for --skip-gitignore option

@pnatashap
Copy link
Contributor Author

@yegor256 please take a look

@php-coder
Copy link
Contributor

Thank you!

Could you, please, add Fixes #222 into the PR description?

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jan 19, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 2215a6b into cqfn:master Jan 19, 2024
5 checks passed
@rultor
Copy link
Collaborator

rultor commented Jan 19, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 2min)

@php-coder
Copy link
Contributor

Could you, please, add Fixes #222 into the PR description?

Ok, it's late now. I'll close it manually.

@php-coder php-coder mentioned this pull request Jan 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pnatashap @php-coder @yegor256 @rultor