Update html.js #575
Open
Update html.js #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not always possible to send id of the html. In such cases we can use data-printid attribute.
i prefer using a common css selector, not just a data-printid attribute. can you please update your PR for me? :) |
nelsonkuang
reviewed
Sep 2, 2021
| @@ -5,7 +5,12 @@ export default { | |||
| print: (params, printFrame) => { | |||
| // Get the DOM printable element | |||
| const printElement = isHtmlElement(params.printable) ? params.printable : document.getElementById(params.printable) | |||
There was a problem hiding this comment.
let printElement = isHtmlElement(params.printable) ? params.printable : document.getElementById(params.printable)
nelsonkuang
reviewed
Sep 2, 2021
|
|
||
|
|
||
| // check if data-printid for the element exist | ||
| if (!printElement) { |
There was a problem hiding this comment.
if (!printElement && document.querySelector) {
printElement = document.querySelector(params.printable);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not always possible to send id of the html. In such cases we can use data-printid attribute.