fix(vtfpp): use sourcepp makeFourCC helper for signature

include/sourcepp/parser/Binary.h

@@ -16,10 +16,7 @@ namespace sourcepp::parser::binary {
  * @param fourCC The human-readable FourCC.
  * @return The FourCC identifier.
  */
-consteval uint32_t makeFourCC(std::string_view fourCC) {
-	if (fourCC.length() != 4) {
-		return 0;
-	}
+consteval uint32_t makeFourCC(const char fourCC[4]) {
 	return fourCC[0] | (fourCC[1] << 8) | (fourCC[2] << 16) | (fourCC[3] << 24);
 }
 

include/vtfpp/vtfpp.h

@@ -11,12 +11,13 @@
 #include <vector>
 
 #include <sourcepp/math/Vector.h>
+#include <sourcepp/parser/Binary.h>
 
 #include "ImageFormats.h"
 
 namespace vtfpp {
 
-constexpr int32_t VTF_SIGNATURE = 'V' + ('T' << 8) + ('F' << 16);
+constexpr uint32_t VTF_SIGNATURE = sourcepp::parser::binary::makeFourCC("VTF\0");
 
 struct Resource {
 	enum Type : uint8_t {
@@ -41,11 +42,11 @@ struct Resource {
 	std::span<std::byte> data;
 
 	using ConvertedData = std::variant<
-			std::monostate, // Anything that would be equivalent to just returning data directly, or used as an error
-			uint32_t, // CRC, TSO
-			std::pair<uint8_t, uint8_t>, // LOD
-			std::string, // KVD
-			std::span<uint32_t> // AXC
+		std::monostate, // Anything that would be equivalent to just returning data directly, or used as an error
+		uint32_t, // CRC, TSO
+		std::pair<uint8_t, uint8_t>, // LOD
+		std::string, // KVD
+		std::span<uint32_t> // AXC
 	>;
 	[[nodiscard]] ConvertedData convertData() const;
 
@@ -182,7 +183,7 @@ class VTF {
 
 	std::vector<std::byte> data;
 
-	//int32_t signature;
+	//uint32_t signature;
 	uint32_t majorVersion{};
 	uint32_t minorVersion{};
 

src/vtfpp/vtfpp.cpp

@@ -43,7 +43,7 @@ VTF::VTF(std::vector<std::byte>&& vtfData, bool parseHeaderOnly)
 		: data(std::move(vtfData)) {
 	BufferStreamReadOnly stream{this->data};
 
-	if (stream.read<int32_t>() != VTF_SIGNATURE) {
+	if (stream.read<uint32_t>() != VTF_SIGNATURE) {
 		return;
 	}