Skip to content

Fix bad description for resourceBaseUrl #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ccchapman
Copy link
Contributor

Description

Related issues

@ccchapman ccchapman requested a review from a team as a code owner March 21, 2025 21:39
Copy link

netlify bot commented Mar 21, 2025

👷 Deploy request for craft-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c9a4c2a

@AugustMiller
Copy link
Contributor

Hey! This file is automatically generated from the GeneralConfig class, so this will be overwritten on the next release.

Could you elaborate on the language change so that I can make the equivalent upstream PR? It may be a bit roundabout/convoluted, but the "publishing" process it describes is a key part of Yii's assets system, so I'm inclined to retain as much of this as possible!

@ccchapman
Copy link
Contributor Author

ccchapman commented Mar 25, 2025

Hey! This file is automatically generated from the GeneralConfig class, so this will be overwritten on the next release.

Could you elaborate on the language change so that I can make the equivalent upstream PR? It may be a bit roundabout/convoluted, but the "publishing" process it describes is a key part of Yii's assets system, so I'm inclined to retain as much of this as possible!

Seems to me a bad copy/paste of the resourceBasePath description. resourceBaseUrl wouldn't change where anything is stored, it just needs to map to where resourceBasePath is accessible on the internet.

@AugustMiller
Copy link
Contributor

Ahh, I hear you—pushed up some changes to craftcms/cms that should make these descriptions more distinct!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants